Closed
Conversation
That method alias didn't work
Martchus
reviewed
Dec 11, 2024
Collaborator
Martchus
left a comment
Martchus
left a comment
There was a problem hiding this comment.
We don't use this alisas in openQA or os-autoinst so I suppose this can be merged from our side. Of course it is nevertheless generally a breaking change. So it would maybe be better to add the corrected alias only in addition. Or we leave it completely unchanged because one can simply use channel_in and channel_out anyway.
Author
|
Yeah, makes sense, it's not like I had a need for it. AFAICS it's undocumented anyway, it just tickled my OCD ;) |
okurz
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That method alias probably wasn't meant like this.